Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(styles): implemented radio-button styles using tokens #3803

Closed
wants to merge 17 commits into from
Closed

feat(styles): implemented radio-button styles using tokens #3803

wants to merge 17 commits into from

Conversation

schaertim
Copy link
Contributor

No description provided.

@schaertim schaertim linked an issue Oct 23, 2024 that may be closed by this pull request
[component]: Radio Button (rework) #3537
Open
7 tasks
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 5488b2c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@swisspost/design-system-styles Minor
@swisspost/design-system-documentation Minor
@swisspost/design-system-components-angular-workspace Patch
@swisspost/design-system-components Minor
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header-workspace Patch
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-styles-primeng-workspace Patch
@swisspost/design-system-intranet-header Minor
@swisspost/design-system-styles-primeng Minor
@swisspost/design-system-components-react Minor
@swisspost/design-system-components-angular Minor
@swisspost/design-system-intranet-header-showcase Patch
@swisspost/design-system-tokens Minor
@swisspost/design-system-icons Minor
@swisspost/design-system-migrations Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Oct 23, 2024 •
edited
Loading

Related Previews

@schaertim schaertim changed the title 3537 component radio button rework feat(styles): implemented radio-button styles using tokens Oct 23, 2024
@schaertim schaertim marked this pull request as ready for review October 23, 2024 08:15
@schaertim schaertim requested review from a team as code owners October 23, 2024 08:15
gfellerph
gfellerph requested changes Oct 24, 2024
View reviewed changes
Copy link
Member

@gfellerph gfellerph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a changeset to this PR, similar to the one for the checkbox?

packages/styles/src/elements/fieldset-legend.scss Outdated Show resolved Hide resolved
packages/styles/index.html Outdated Show resolved Hide resolved
packages/styles/src/components/_form-check.scss Outdated Show resolved Hide resolved
packages/styles/src/components/_form-check.scss Outdated Show resolved Hide resolved
packages/styles/src/components/radio-button.scss Outdated Show resolved Hide resolved
packages/styles/src/components/radio-button.scss Outdated Show resolved Hide resolved
packages/styles/src/components/radio-button.scss Outdated Show resolved Hide resolved
packages/styles/src/components/radio-button.scss Outdated Show resolved Hide resolved
packages/styles/src/components/radio-button.scss Outdated Show resolved Hide resolved
@schaertim schaertim linked an issue Oct 29, 2024 that may be closed by this pull request
[component]: Radio button #3274
Open
4 tasks
@alizedebray alizedebray modified the milestone: PPNL Components Oct 30, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Nov 6, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/[email protected]

View full report↗︎

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@schaertim schaertim closed this Nov 14, 2024
This was unlinked from issues Nov 14, 2024
[component]: Radio button #3274
Open
[component]: Radio Button (rework) #3537
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfellerph gfellerph gfellerph requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
PPNL Components
Development

Successfully merging this pull request may close these issues.
4 participants
@schaertim @swisspost-bot @gfellerph @alizedebray